You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I believe a bug may have been introduced in #42. It causes methods to be ordered inconsistently. Probably because we're now scraping the wiki multiple pages at a time, causing for inconsistent load results between scrapes.
It's most noticeable when you compare recent commit changes: 4af9755 (which show a large amount of changes occurring) to those from before #42. These show only changes to the wiki data, without reordering methods: bd6de32
As for the "method definitions are placed before the local ContentIcon = {}:" issue, I guess this only affects panels since they do not write a fallback class definition? Should be easily fixable though.
@robotboy655 Thanks for picking this up. Just confirming that comparing the most recent commit to one from two weeks ago helpfully shows changes made to the content (and doesn't reorder): /bd6de32d69108e1e68fbaa516f42fa4145cdd811...lua-language-server-addon
So all is good again + even beter since all the new changes you made.
Thanks for implementing the fix the clean way you did and with the speed you did it!
I believe a bug may have been introduced in #42. It causes methods to be ordered inconsistently. Probably because we're now scraping the wiki multiple pages at a time, causing for inconsistent load results between scrapes.
It's most noticeable when you compare recent commit changes: 4af9755 (which show a large amount of changes occurring) to those from before #42. These show only changes to the wiki data, without reordering methods: bd6de32
Additionally this bug causes the following side-effect, where some method definitions are placed before the
local ContentIcon = {}
:https://github.com/luttje/glua-api-snippets/blob/4af9755c9657221ea8d6294aace24496aab884e7/library/contenticon.lua
@robotboy655 Would love your feedback, do you recognize an easy fix? I'm thinking a sort somewhere might solve this issue, e.g: in here:
glua-api-snippets/src/api-writer/glua-api-writer.ts
Line 73 in b443e9f
The text was updated successfully, but these errors were encountered: