nsh_dd: fix lseek return check.

Denis Ryndine · xiaoxiang781216 · commit a15403958d56 · 2024-08-01T09:52:03.000+08:00
- As was merged in commit 1852731 on dd_main.c: lseek returns -1 on error. Should be consistent in nsh_ddcmd.c and nsh_main.c.
diff --git a/nshlib/nsh_ddcmd.c b/nshlib/nsh_ddcmd.c
@@ -385,7 +385,7 @@ int cmd_dd(FAR struct nsh_vtbl_s *vtbl, int argc, FAR char **argv)
   if (dd.skip)
     {
       ret = lseek(dd.infd, dd.skip * dd.sectsize, SEEK_SET);
-      if (ret < -1)
+      if (ret < 0)
         {
           nsh_error(vtbl, g_fmtcmdfailed, g_dd, "skip lseek", NSH_ERRNO);
           ret = ERROR;
@@ -396,7 +396,7 @@ int cmd_dd(FAR struct nsh_vtbl_s *vtbl, int argc, FAR char **argv)
   if (dd.seek)
     {
       ret = lseek(dd.outfd, dd.seek * dd.sectsize, SEEK_SET);
-      if (ret < -1)
+      if (ret < 0)
         {
           nsh_error(vtbl, g_fmtcmdfailed, g_dd, "seek lseek", NSH_ERRNO);
           ret = ERROR;

Original file line number	Diff line number	Diff line change
`@@ -385,7 +385,7 @@ int cmd_dd(FAR struct nsh_vtbl_s vtbl, int argc, FAR char *argv)`
`385`	`385`	`if (dd.skip)`
`386`	`386`	`{`
`387`	`387`	`ret = lseek(dd.infd, dd.skip * dd.sectsize, SEEK_SET);`
`388`		`- if (ret < -1)`
	`388`	`+ if (ret < 0)`
`389`	`389`	`{`
`390`	`390`	`nsh_error(vtbl, g_fmtcmdfailed, g_dd, "skip lseek", NSH_ERRNO);`
`391`	`391`	`ret = ERROR;`
`@@ -396,7 +396,7 @@ int cmd_dd(FAR struct nsh_vtbl_s vtbl, int argc, FAR char *argv)`
`396`	`396`	`if (dd.seek)`
`397`	`397`	`{`
`398`	`398`	`ret = lseek(dd.outfd, dd.seek * dd.sectsize, SEEK_SET);`
`399`		`- if (ret < -1)`
	`399`	`+ if (ret < 0)`
`400`	`400`	`{`
`401`	`401`	`nsh_error(vtbl, g_fmtcmdfailed, g_dd, "seek lseek", NSH_ERRNO);`
`402`	`402`	`ret = ERROR;`