feat: support standard PEM bundles #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
lukegb
requested changes
Feb 7, 2024
The `shell.nix` was pinning various things like Python 3.9, specific versions of dependencies, had a reference to Python 2, was using a removed package / moved package (pre-commit) and was overriding `reuse` to inject a specific set of packages. All of this is cleaned up and the shell is now using Python 3.12 if you are using a recent Nixpkgs, at the time of writing. In addition, `pytest` and `pre-commit` are still behaving as expected. Signed-off-by: Ryan Lahfa <ryan@lahfa.xyz>
lukegb
reviewed
Feb 11, 2024
buildcatrust/certstore_output.py
Outdated
Comment on lines
38
to
43
|
|
||
| def __init__(self, fp: TextIO): | ||
| self.fp = fp | ||
|
|
||
| def output(self, cert: Optional[types.Certificate], trust: types.Trust) -> None: | ||
| super().output(cert, trust) |
There was a problem hiding this comment.
This doesn't do anything different to the parent class; maybe just delete everything here apart from the docstring?
There was a problem hiding this comment.
Oops, thank you for taking care of it.
|
One more thing :) Also urgh, I should fix the cachix thing. |
Some software stack may not be able to enjoy OpenSSL specific PEM formats. To pay respect to the standard, we offer a compatible bundle output which strips all additional trust rules of a given certificate, if there's any. Tests show how this has concretely an impact over distrusted certificates, i.e. you don't see anything about it. Signed-off-by: Ryan Lahfa <ryan@lahfa.xyz>
|
Thank you @lukegb ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
NixOS does not ship a cacert bundle that can be used with software stacks that does not support OpenSSL specific (non-standard) PEM format, this offers an escape hatch for such users.
shell.nixThe
shell.nixwas pinning various things like Python 3.9, specific versions of dependencies, hada reference to Python 2, was using a removed package / moved package (pre-commit) and was overriding
reuseto inject a specific set of packages.All of this is cleaned up and the shell is now using Python 3.12 if you are using a recent Nixpkgs, at the time
of writing.
In addition,
pytestandpre-commitare still behaving as expected.