Skip to content

Commit 7a527ff

Browse files
committed
fix: color set option not changing colors
1 parent 2d83192 commit 7a527ff

File tree

2 files changed

+22
-22
lines changed

2 files changed

+22
-22
lines changed

package/contents/ui/code/utils.js

-1
Original file line numberDiff line numberDiff line change
@@ -458,6 +458,5 @@ for (var id of panelIds) {
458458
}
459459

460460
function evaluateScript(script) {
461-
console.error(script)
462461
runCommand.run("gdbus call --session --dest org.kde.plasmashell --object-path /PlasmaShell --method org.kde.PlasmaShell.evaluateScript '" + script + "'")
463462
}

package/contents/ui/main.qml

+22-21
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,6 @@ PlasmoidItem {
142142
Qt.callLater(function() {
143143
console.error(JSON.stringify(stockPanelSettings))
144144
let script = Utils.setPanelModeScript(panelPosition, stockPanelSettings)
145-
console.error("script", script)
146145
Utils.evaluateScript(script)
147146
})
148147
}
@@ -176,23 +175,14 @@ PlasmoidItem {
176175
updateMasks()
177176
}
178177

179-
Rectangle {
180-
id: colorHolder
181-
height: 0
182-
width: 0
183-
visible: false
184-
Kirigami.Theme.inherit: false
185-
}
186-
187-
function getColor(colorCfg, targetIndex, parentColor, itemType) {
178+
function getColor(colorCfg, targetIndex, parentColor, itemType, kirigamiColorItem) {
188179
let newColor = "transparent"
189180
switch (colorCfg.sourceType) {
190181
case 0:
191182
newColor = Utils.rgbToQtColor(Utils.hexToRgb(colorCfg.custom))
192183
break
193184
case 1:
194-
colorHolder.Kirigami.Theme.colorSet = Kirigami.Theme[colorCfg.systemColorSet]
195-
newColor = colorHolder.Kirigami.Theme[colorCfg.systemColor]
185+
newColor = kirigamiColorItem.Kirigami.Theme[colorCfg.systemColor]
196186
break
197187
case 2:
198188
const nextIndex = targetIndex % colorCfg.list.length
@@ -410,11 +400,11 @@ PlasmoidItem {
410400
} else if ((!fgEnabled && inTray && widgetEnabled)) {
411401
return trayWidgetBgItem.fgColor
412402
} else if (separateTray || cfgOverride) {
413-
return getColor(rect.fgColorCfg, targetIndex, rect.color, itemType)
403+
return getColor(rect.fgColorCfg, targetIndex, rect.color, itemType, fgColorHolder)
414404
} else if (inTray) {
415-
return getColor(widgetSettings.foregroundColor, trayIndex, rect.color, itemType)
405+
return getColor(widgetSettings.foregroundColor, trayIndex, rect.color, itemType, fgColorHolder)
416406
} else {
417-
return getColor(widgetSettings.foregroundColor, targetIndex, rect.color, itemType)
407+
return getColor(widgetSettings.foregroundColor, targetIndex, rect.color, itemType, fgColorHolder)
418408
}
419409
}
420410
Rectangle {
@@ -425,6 +415,17 @@ PlasmoidItem {
425415
radius: height / 2
426416
color: fgColor
427417
anchors.right: parent.right
418+
Kirigami.Theme.colorSet: Kirigami.Theme[fgColorCfg.systemColorSet]
419+
}
420+
Rectangle {
421+
id: bgColorHolder
422+
height: 6
423+
width: height
424+
visible: false
425+
radius: height / 2
426+
color: fgColor
427+
anchors.right: parent.right
428+
Kirigami.Theme.colorSet: Kirigami.Theme[bgColorCfg.systemColorSet]
428429
}
429430
// Label {
430431
// id: debugLabel
@@ -437,9 +438,10 @@ PlasmoidItem {
437438
bottomLeftRadius: bottomLeftRadius
438439
bottomRightRadius: bottomRightRadius
439440
}
441+
Kirigami.Theme.colorSet: Kirigami.Theme[bgColorCfg.systemColorSet]
440442
color: {
441443
if (bgEnabled) {
442-
return getColor(bgColorCfg, targetIndex, null, itemType)
444+
return getColor(bgColorCfg, targetIndex, null, itemType, rect)
443445
} else {
444446
return "transparent"
445447
}
@@ -692,9 +694,8 @@ PlasmoidItem {
692694
visible: borderEnabled && Math.min(rect.height, rect.width) > 1
693695
property var borderColorCfg: cfg.border.color
694696
Kirigami.Theme.colorSet: Kirigami.Theme[borderColorCfg.systemColorSet]
695-
Kirigami.Theme.inherit: !(borderColorCfg.sourceType === 1)
696697
property color borderColor: {
697-
return getColor(borderColorCfg, targetIndex, rect.color, itemType)
698+
return getColor(borderColorCfg, targetIndex, rect.color, itemType, borderRec)
698699
}
699700

700701
Rectangle {
@@ -812,7 +813,7 @@ PlasmoidItem {
812813
Kirigami.Theme.colorSet: Kirigami.Theme[shadowColorCfg.systemColorSet]
813814
size: (bgShadowEnabled && Math.min(rect.height, rect.width) > 1) ? bgShadow.size : 0
814815
color: {
815-
return getColor(shadowColorCfg, targetIndex, rect.color, itemType)
816+
return getColor(shadowColorCfg, targetIndex, rect.color, itemType, rect.shadow)
816817
}
817818
xOffset: bgShadow.xOffset
818819
yOffset: bgShadow.yOffset
@@ -847,7 +848,7 @@ PlasmoidItem {
847848
anchors.rightMargin: horizontal ? rect.marginRight : undefined
848849
anchors.topMargin: horizontal ? undefined : rect.marginTop
849850
anchors.bottomMargin: horizontal ? undefined : rect.marginBottom
850-
851+
id: dropShadow
851852
property var shadowColorCfg: fgShadow.color
852853
Kirigami.Theme.colorSet: Kirigami.Theme[shadowColorCfg.systemColorSet]
853854
horizontalOffset: fgShadow.xOffset
@@ -856,7 +857,7 @@ PlasmoidItem {
856857
samples: radius * 2 + 1
857858
spread: 0.35
858859
color: {
859-
return getColor(shadowColorCfg, targetIndex, rect.color, itemType)
860+
return getColor(shadowColorCfg, targetIndex, rect.color, itemType, dropShadow)
860861
}
861862
source: target.applet
862863
visible: fgShadowEnabled

0 commit comments

Comments
 (0)