fix: always apply alpha to avoid inheriting it from parent

luisbocanegra · luisbocanegra · commit 4151f6e2d6e3 · 2025-01-15T15:09:21.000-06:00
diff --git a/package/contents/ui/main.qml b/package/contents/ui/main.qml
@@ -214,17 +214,15 @@ PlasmoidItem {
 
             break
             default:
-                newColor = "transparent"
+                newColor = Qt.hsla(0, 0, 0, 0)
         }
         if (colorCfg.saturationEnabled) {
             newColor = Utils.scaleSaturation(newColor, colorCfg.saturationValue)
         }
         if (colorCfg.lightnessEnabled) {
             newColor = Utils.scaleLightness(newColor, colorCfg.lightnessValue)
         }
-        if (colorCfg.alpha !== 1) {
-            newColor = Qt.hsla(newColor.hslHue, newColor.hslSaturation, newColor.hslLightness, colorCfg.alpha)
-        }
+        newColor = Qt.hsla(newColor.hslHue, newColor.hslSaturation, newColor.hslLightness, colorCfg.alpha)
         return newColor
     }
 

Original file line number	Diff line number	Diff line change
`@@ -214,17 +214,15 @@ PlasmoidItem {`
`214`	`214`
`215`	`215`	`break`
`216`	`216`	`default:`
`217`		`- newColor = "transparent"`
	`217`	`+ newColor = Qt.hsla(0, 0, 0, 0)`
`218`	`218`	`}`
`219`	`219`	`if (colorCfg.saturationEnabled) {`
`220`	`220`	`newColor = Utils.scaleSaturation(newColor, colorCfg.saturationValue)`
`221`	`221`	`}`
`222`	`222`	`if (colorCfg.lightnessEnabled) {`
`223`	`223`	`newColor = Utils.scaleLightness(newColor, colorCfg.lightnessValue)`
`224`	`224`	`}`
`225`		`- if (colorCfg.alpha !== 1) {`
`226`		`- newColor = Qt.hsla(newColor.hslHue, newColor.hslSaturation, newColor.hslLightness, colorCfg.alpha)`
`227`		`- }`
	`225`	`+ newColor = Qt.hsla(newColor.hslHue, newColor.hslSaturation, newColor.hslLightness, colorCfg.alpha)`
`228`	`226`	`return newColor`
`229`	`227`	`}`
`230`	`228`