Skip to content

Commit a24b949

Browse files
authored
Merge pull request kubernetes-sigs#2284 from vincepri/golangcilint152
🌱 Update golangci-lint to v1.52.1
2 parents 1c2a7c9 + e301ba3 commit a24b949

File tree

3 files changed

+124
-98
lines changed

3 files changed

+124
-98
lines changed

.github/workflows/golangci-lint.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,5 +22,5 @@ jobs:
2222
- name: golangci-lint
2323
uses: golangci/golangci-lint-action@v3
2424
with:
25-
version: v1.51.1
25+
version: v1.52.1
2626
working-directory: ${{matrix.working-directory}}

.golangci.yml

+29-3
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,35 @@ linters-settings:
6666
include-go-root: true
6767
packages:
6868
- io/ioutil # https://go.dev/doc/go1.16#ioutil
69+
revive:
70+
rules:
71+
# The following rules are recommended https://github.com/mgechev/revive#recommended-configuration
72+
- name: blank-imports
73+
- name: context-as-argument
74+
- name: context-keys-type
75+
- name: dot-imports
76+
- name: error-return
77+
- name: error-strings
78+
- name: error-naming
79+
- name: exported
80+
- name: if-return
81+
- name: increment-decrement
82+
- name: var-naming
83+
- name: var-declaration
84+
- name: range
85+
- name: receiver-naming
86+
- name: time-naming
87+
- name: unexported-return
88+
- name: indent-error-flow
89+
- name: errorf
90+
- name: superfluous-else
91+
- name: unreachable-code
92+
- name: redefines-builtin-id
93+
#
94+
# Rules in addition to the recommended configuration above.
95+
#
96+
- name: bool-literal-in-expr
97+
- name: constant-logical-expr
6998

7099
issues:
71100
max-same-issues: 0
@@ -133,9 +162,6 @@ issues:
133162
- linters:
134163
- gosec
135164
text: "G304: Potential file inclusion via variable"
136-
- linters:
137-
- revive
138-
text: "package-comments: should have a package comment"
139165
- linters:
140166
- dupl
141167
path: _test\.go

0 commit comments

Comments
 (0)