Skip to content

Chore: Adjust messages filter and get-messages Request #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 9, 2025

Conversation

julian-wls
Copy link
Contributor

@julian-wls julian-wls commented Apr 2, 2025

Problem Description

With this PR a new structure for the messages GET endpoint will be implemented.

Changes

This PR makes the necessary adjustments to the Android app.

Steps for testing

Make sure you're using a test-server with the new API changes applied (TS2 as of writing this)

  1. Go to any conversation
  2. Make sure the messages filter works as expected.
  3. Make sure the conversation filter works as expected.
  4. Make sure messages are loaded as expected.

@julian-wls julian-wls self-assigned this Apr 2, 2025
@julian-wls julian-wls linked an issue Apr 2, 2025 that may be closed by this pull request
@julian-wls julian-wls added the api calls Attention when merging because of the recent 8.0.0 breaking changes label Apr 3, 2025
@julian-wls julian-wls marked this pull request as ready for review April 9, 2025 08:17
@julian-wls julian-wls added the ready for review This PR can be reviewed label Apr 9, 2025
@julian-wls julian-wls requested a review from FelberMartin April 9, 2025 08:18
Copy link
Collaborator

@FelberMartin FelberMartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on TS2, loading and filtering messages works. Code lgtm

@FelberMartin FelberMartin added ready to merge This PR can be merged and removed ready for review This PR can be reviewed labels Apr 9, 2025
@FelberMartin FelberMartin merged commit 621a3e5 into develop Apr 9, 2025
5 checks passed
@FelberMartin FelberMartin deleted the chore/communication/adapt-messages-endpoint branch April 9, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api calls Attention when merging because of the recent 8.0.0 breaking changes ready to merge This PR can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update message search API
2 participants