Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: support npm_config_sharp_dist_base_url (in addition to SHARP_DIST_BASE_URL) #1418

Closed
SethWen opened this issue Oct 19, 2018 · 2 comments
Closed

Enhancement: support npm_config_sharp_dist_base_url (in addition to SHARP_DIST_BASE_URL) #1418

SethWen opened this issue Oct 19, 2018 · 2 comments
Labels
enhancement ready-to-ship
Milestone
v0.21.1

Comments

@SethWen
Copy link

SethWen commented Oct 19, 2018

suggestion: add process.env.npm_config_sharp_dist_base_url in libvips-*.tar.gz download base url, then we can config it in npmrc file.
That means in ./install/livavips.js file:
const distBaseUrl = process.env.npm_config_sharp_dist_base_url || process.env.SHARP_DIST_BASE_URL || https://github.com/lovell/sharp-libvips/releases/download/v${minimumLibvipsVersion}/`;`
@lovell
Copy link
Owner

lovell commented Oct 19, 2018

Hello, this seems like a sensible idea, happy to accept a PR with this change if you're able.

@lovell lovell changed the title add_npmrc_download_url Enhancement: support npm_config_sharp_dist_base_url (in addition to SHARP_DIST_BASE_URL) Oct 19, 2018
@SethWen SethWen mentioned this issue Oct 22, 2018
Merged
@lovell lovell added this to the v0.21.1 milestone Oct 22, 2018
@lovell
Copy link
Owner

lovell commented Dec 7, 2018

v0.21.1 is now available, thank you for the PR.

@lovell lovell closed this as completed Dec 7, 2018
@ghost ghost mentioned this issue Apr 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement ready-to-ship
Projects
None yet
Milestone
v0.21.1
Development

No branches or pull requests
2 participants
@lovell @SethWen