Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made some suggestions #178

Closed
hefeng6500 opened this issue Aug 25, 2021 · 2 comments
Closed

Made some suggestions #178

hefeng6500 opened this issue Aug 25, 2021 · 2 comments

Comments

@hefeng6500
Copy link

Hi loiane

I am the Chinese reader of your book "Learning javascript data structure and algorithm". I am studying the AVL tree and found a line of code in the method of removeNode that is unnecessary,

link this

this.getBalanceFactor(node.left) === BalanceFactor.BALANCED

Because I think if the tree is balanced, there is no need to move

additionally,I submitted a request in the project , do you have permission to merge the code for me?

PR: PacktPublishing/Learning-JavaScript-Data-Structures-and-Algorithms-Third-Edition#12

Looking forward to your response!

@Jeffzholy
Copy link

Jeffzholy commented May 17, 2022

Hey @loiane , think this issue is fixed by this PR #193. And also @hefeng6500, your issue description is not related with the PR that you mentioned in the description? In a word this issue can be safely closed

@loiane
Copy link
Owner

loiane commented May 18, 2022

@Jeffzholy thanks!

@loiane loiane closed this as completed May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants