Fix undefined issue while logging from node-loggly-bulk library #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I debugged code with
node-loggly-bulk
library and found that type ofmsg
is a string which should be an object(winston-loggly-bulk
library is sending log data tonode-loggly-bulk
in object form). That's why the value ofmsg.message
object wasundefined
.From node version 7.0.0, node will throw an error when we will pass invalid input to Buffer.byteLength.
Ref: https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V7.md#7.0.0
Merged PR: nodejs/node#8946
In this PR I have put a condition to check if the
msg
is a string (If we are logging usingnode-loggly-bulk
) and then converting to an object. So both library will work correctly.It will fix the issue #10.