refactor git pull (#364)

Author: ckrause

src/cmd/boinc.cpp

@@ -128,7 +128,7 @@ void Boinc::run() {
     const auto progs_dir = Setup::getProgramsHome();
     FolderLock lock(project_dir);
     if (Setup::existsProgramsHome() &&  // need to check again here
-        !Git::git(progs_dir, "pull origin main -q --ff-only", false)) {
+        !Setup::pullProgramsHome(false)) {
       Log::get().error("Failed to update programs repository", false);
       const auto age = getFileAgeInDays(progs_dir);
       Log::get().info("Programs directory age: " + std::to_string(age) +

src/oeis/oeis_manager.cpp

@@ -392,7 +392,7 @@ void OeisManager::update(bool force) {
       }
       Log::get().info(msg);
       // update programs repository using git pull
-      Git::git(progs_dir, "pull origin main -q --ff-only");
+      Setup::pullProgramsHome();
     }
 
     // touch marker file to track the age (even in server mode)

src/sys/setup.cpp

@@ -160,6 +160,11 @@ void Setup::cloneProgramsHome(const std::string& git_url) {
   Git::clone(git_url, getLodaHome() + "programs");
 }
 
+bool Setup::pullProgramsHome(bool fail_on_error) {
+  return Git::git(getProgramsHome(), "pull origin main -q --ff-only",
+                  fail_on_error);
+}
+
 void Setup::checkDir(const std::string& home) {
   if (!isDir(home)) {
     Log::get().error(

src/sys/setup.hpp

@@ -46,6 +46,8 @@ class Setup {
       const std::string& git_url =
           "https://github.com/loda-lang/loda-programs.git");
 
+  static bool pullProgramsHome(bool fail_on_error = true);
+
   static std::string getSetupValue(const std::string& key);
 
   static bool getSetupFlag(const std::string& key, bool default_value);