avoid modernize-avoid-c-arrays warning with templates that deduce array length

[firewave]

#include <cstdint>

template<typename T, int size>
std::size_t arrayLen(const T (& /*unused*/)[size])
{
    return size;
}

<source>:4:28: warning: do not declare C-style arrays, use std::array<> instead [modernize-avoid-c-arrays]
std::size_t arrayLen(const T (& /*unused*/)[size])
                           ^

https://godbolt.org/z/bvWbTqP1f

In our case this is used to get the length of a string literal. It doesn't make sense to use std::array for that.

So before C++17 you can only suppress this as std::string_view, which would allow to get rid of this, is not yet available.

[llvmbot]

@llvm/issue-subscribers-clang-tidy