fix cloning of buffers #2
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Properly handles cloning of buffers in Node.js and browser environments.
ljharb
requested changes
Jul 20, 2023
|
@ljharb Could you please review after my latest changes? |
ljharb
reviewed
Jul 24, 2023
ljharb
reviewed
Jul 24, 2023
Comment on lines
+66
to
+99
| } else if (isBuffer(src)) { | ||
| dst = Buffer.from(src); |
There was a problem hiding this comment.
Suggested change
| } else if (isBuffer(src)) { | |
| dst = Buffer.from(src); | |
| } else if (isBuffer(src) && typeof Buffer.from === 'function') { | |
| dst = Buffer.from(src); |
i'm a bit concerned that merely mentioning Buffer would cause bundlers to bring in the buffer polyfill unnecessarily, which is why the isBuffer code is authored the way it is.
There was a problem hiding this comment.
I'm still concerned here - I don't think we can use Buffer.from without incurring a bundle size impact. I think we could use the safe-buffer package, but then we need to add a dependency.
Merged
ljharb
force-pushed
the
clone-buffer
branch
from
b680012 to
598a5c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly handles cloning of
Bufferobjects in Node.js.Without this fix,
Bufferobjects would get corrupted after cloning as is demonstrated by the unit test.