-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Authentication Module Refactor #2483
Comments
@rajdas98 @ajeshbaby I'm interested in this project. Could you help me with some resources to begin |
Hi @Debanitrkl, This issue is locked for GSoC 2021, Feel free to send a proposal once GSoC announces this project. |
@rajdas98 hi sir i am interested to contribute to this project in GSoC 2021 . Could you provide me with some additional resources if available . I did study the code of the authentication server ( https://github.com/litmuschaos/litmus/tree/master/litmus-portal/authentication ) . I believe the gmail auth and github auth is yet not implemented . |
Yes sir I'm interested for contributing through GSoC, would start writing my proposal soon, just wanted to get started with the code base of authentication server |
@rajdas98 the current auth setup uses "mgo" go package which is not well maintained as compared to the official go.mongodb.org/mongo-driver/mongo driver , should we prefer using the official mongo-driver in the new api ? |
Yes you have to use the official mongo go driver |
There is no session management I believe, we use jwt tokens for authorization so session management in the true sense is not needed in our case. |
okay sir thanks . |
@specter25 , Currently, we are not planning to use other db. The goal of this project is to make the auth-server light-weight and add other thirty party integration. |
Okay sir got it . |
@rajdas98 by light-weight, in what aspects is it expected to be light? lesser third party dependencies? or more memory efficient paradigms of code? A quick gist would be insightful! |
Currently, authentication-server has a lot of unnecessary code complexity and uses some outdated packages like mgo. Also, we have seen authentication-server taking more memory than graphql-server. The first goal of this project would be to rewrite/refactor to make it simple, light-weight and modular, and the second goal is to add the google and GitHub auth integration. @gdsoumya Do you want to add anything? |
I don't think we need refresh tokens, this will change the auth flow which we don't want to do right now. Adding refresh tokens will also need to be complemented with blacklisting or revoke feature or else it will be vulnerable to attacks. Currently I think asking the user to log back in is a better approach and more secure, because if by chance the refresh token is exposed(and goes undetected) the attacker can gain access to critical resources which we do not want. |
Yeah i agree . Got it . Thanks for helping :) |
Hi folks,
Note(s):
Best of luck, |
sure sir . Thanks for the heads up :) |
Hi folks, |
sure sir . |
The text was updated successfully, but these errors were encountered: