-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decide what to do with uaccess.h constness #186
Comments
GCC doesn't warn on https://bugs.llvm.org/show_bug.cgi?id=32985 https://lore.kernel.org/lkml/CAK8P3a1y0MoxhMNr2v=R7-CANaATfFy58FM8heyOP78g-JZwHA@mail.gmail.com/ |
We ended up doing the revert of dja's patch which will land in 4.20: https://patchwork.ozlabs.org/patch/969614/ In addition, clang has fixed this to match GCC's behaviour, which will appear in the clang 8 release. |
I don't think @daxtens original patch was actually fixing a sparse warning was it? It was just a "hey const makes sense here so let's use it". |
No it was fixing a warning:
https://lore.kernel.org/linuxppc-dev/20170130064155.30281-1-dja@axtens.net/ But I don't seem to be seeing them as of now, so perhaps they've gone away for some other reason. |
Back in b91c1e3e7a6f22a6b898e345b745b6a43273c973 (powerpc: Fix duplicate const clang warning in user access code, May 2015) Anton removed the const specifiers from the __get_user macros to fix clang warnings.
in f84ed59a612d866cde0bd17ad2a52acb524d44c9 (powerpc/sparse: Constify the address pointer in __get_user_check()) and similar commits, dja re-added these to fix some sparse warnings.
The clang warnings are still there. I assume if we undo Daniel's changes we will reintroduce the sparse warnings. Which should we choose?
The text was updated successfully, but these errors were encountered: