fix: [M3-7138] - Fix Create Volume Drawer static pricing copy and misplaced helper text (#9683)

* Fix Create Volume Drawer static pricing copy and misplaced helper text

* Added changeset: Misplaced helper text and static copy in Linode Create Volume drawer

* Update variable name to be more clear

Author: mjac0bs

packages/manager/.changeset/pr-9683-fixed-1694731625764.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Fixed
+---
+
+Misplaced helper text and static copy in Linode Create Volume drawer ([#9683](https://github.com/linode/manager/pull/9683))

packages/manager/src/features/Volumes/VolumeCreate/CreateVolumeForm.tsx

@@ -281,9 +281,9 @@ const CreateVolumeForm: React.FC<CombinedProps> = (props) => {
                 >
                   {dcSpecificPricing ? (
                     <span>
-                      A single Volume can range from 10 to 10240 GB in size. Up
-                      to eight Volumes can be attached to a single Linode.
-                      Select a region to see cost per GB.
+                      A single Volume can range from 10 to {MAX_VOLUME_SIZE} GB
+                      in size. Up to to eight Volumes can be attached to a
+                      single Linode. Select a region to see cost per GB.
                     </span>
                   ) : (
                     <span>

packages/manager/src/features/Volumes/VolumeDrawer/CreateVolumeForLinodeForm.tsx

@@ -197,9 +197,18 @@ const CreateVolumeForm: React.FC<CombinedProps> = (props) => {
               data-qa-volume-size-help
               variant="body1"
             >
-              A single Volume can range from 10 to {MAX_VOLUME_SIZE} gigabytes
-              in size and costs $0.10/GB per month. Up to eight volumes can be
-              attached to a single Linode.
+              {flags.dcSpecificPricing ? (
+                <span>
+                  A single Volume can range from 10 to {MAX_VOLUME_SIZE} GB in
+                  size. Up to eight Volumes can be attached to a single Linode.
+                </span>
+              ) : (
+                <span>
+                  A single Volume can range from 10 to {MAX_VOLUME_SIZE} GB in
+                  size and costs $0.10/GB per month. <br />
+                  Up to eight volumes can be attached to a single Linode.
+                </span>
+              )}
             </Typography>
 
             <LabelField

packages/manager/src/features/Volumes/VolumeDrawer/SizeField.tsx

@@ -77,17 +77,15 @@ const SizeField: React.FC<CombinedProps> = (props) => {
     size: value,
   });
 
-  const legacyHelperText = (
+  const priceDisplayText = (
     <FormHelperText>
-      {resize || isFromLinode ? (
-        'The size of the new volume in GB.'
-      ) : (
+      {resize || isFromLinode ? null : (
         <span className={classes.createVolumeText}>${price}/month</span>
       )}
     </FormHelperText>
   );
 
-  const dynamicPricingHelperText = !resize && (
+  const dynamicPricingHelperText = !resize && !isFromLinode && (
     <Box marginLeft={'10px'} marginTop={'4px'}>
       <Typography>Select a region to see cost per month.</Typography>
     </Box>
@@ -115,9 +113,9 @@ const SizeField: React.FC<CombinedProps> = (props) => {
       <div className={classes.priceDisplay}>
         {dcSpecificPricing
           ? hasSelectedRegion
-            ? legacyHelperText
+            ? priceDisplayText
             : dynamicPricingHelperText
-          : legacyHelperText}
+          : priceDisplayText}
       </div>
     </>
   );