feat: add slider widget with horizontal and vertical support #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement Slider widget with customizable colors, step size, and radii - Add horizontal and vertical axis support with proper coordinate handling - Include hover effects and accessibility features - Add comprehensive tests for interaction and rendering - Integrate slider into widget gallery example with direction switching - Add documentation and example usage - Fix edge cases for min/max values and step adjustments
DJMcNab
reviewed
Feb 5, 2025
|
|
||
| #[must_use] | ||
| /// Set the callback for editing state changes. | ||
| pub fn on_editing_changed( |
There was a problem hiding this comment.
I was hoping to see some use case for this.
Also "editing state changes" is extremely vague terminology.
- Move slider-related constants from Slider impl to theme module - Change color fields from Color to Brush type for better flexibility - Rename color-related methods to thumb_color for clarity - Remove macro-based property handling in favor of explicit updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is still an issue where my tests are not outputting images for some reason. Can anyone help me with this?