Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ARCHITECTURE.md file #849

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Update ARCHITECTURE.md file #849

merged 1 commit into from
Feb 17, 2025

Conversation

PoignardAzur
Copy link
Contributor

@PoignardAzur PoignardAzur commented Jan 23, 2025 •
edited
Loading

No description provided.

@PoignardAzur
Update ARCHITECTURE.md file
87662ba 
Note: some of the doc depends on #832 and #848 which haven't been merged yet.
DJMcNab
DJMcNab approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed this PR being opened.

I see that this follow extantly doesn't follow our one sentence per line guidelines. I'd like any new writings to follow that, but I'm not going to block on it here.

@PoignardAzur PoignardAzur added this pull request to the merge queue Feb 17, 2025
@PoignardAzur
Copy link
Contributor Author

I see that this follow extantly doesn't follow our one sentence per line guidelines. I'd like any new writings to follow that, but I'm not going to block on it here.

I remember deliberately choosing to do this, because I expect this file to mostly be read for text editors and the "one line per sentence" approach hurts readability there. I don't know if I'd stand by that reasoning.

Merged via the queue into main with commit f8a7690 Feb 17, 2025
18 checks passed
@PoignardAzur PoignardAzur deleted the rewrite_archicture_md branch February 17, 2025 21:12
eugenesvk pushed a commit to eugenesvk/xilem that referenced this pull request Feb 18, 2025
@PoignardAzur @eugenesvk
Update ARCHITECTURE.md file (linebender#849)
e04a019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DJMcNab DJMcNab DJMcNab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PoignardAzur @DJMcNab