Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Id type in src/id.rs #168

Closed
nicoburns opened this issue Feb 7, 2024 · 2 comments
Closed

Rename Id type in src/id.rs #168

nicoburns opened this issue Feb 7, 2024 · 2 comments

Comments

@nicoburns
Copy link
Contributor

          `Id` is kind of an awful name for this type, although this PR isn't really the place to fix it

Originally posted by @DJMcNab in #166 (comment)

@DJMcNab
Copy link
Member

DJMcNab commented Feb 7, 2024

To clarify, because the original comment wasn't constructive:

The type name tells you nothing about what the type is for (and the documentation also doesn't help). I also don't think this type is the identifier for "everything", i.e. both views and widgets, which might have justified this current name.

(Although I've not dug into the code to investigate this)

@DJMcNab
Copy link
Member

DJMcNab commented Jun 4, 2024

The mentioned file is now gone, since #290

The ids are now ViewId in Xilem and WidgetId in Masonry.

@DJMcNab DJMcNab closed this as completed Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants