Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background filter uses unexistent Color class #703

Closed
mangelsnc opened this issue Jan 27, 2016 · 8 comments
Closed

Background filter uses unexistent Color class #703

mangelsnc opened this issue Jan 27, 2016 · 8 comments

Comments

@mangelsnc
Copy link
Contributor

A few years ago, this bug was reported: #449 and it was fixed in this commit: 2e11afe

But five days ago I see that this bug seems to be reintroduced by this commit: e07cc0d

This causes failing in some Imagine Library version, such as 0.6.

Is this correct?

@makasim
Copy link
Collaborator

makasim commented Jan 27, 2016

No it is not, and the PR merged few days ago has to be reverted.

@makasim
Copy link
Collaborator

makasim commented Jan 27, 2016

Or we have to stricter the version of imagine we rely on and use the recommended there way of manipulating with background.

@perk11
Copy link

perk11 commented Feb 5, 2016

Also affected by this.

@gburgi
Copy link

gburgi commented Feb 11, 2016

Also here...

@makasim
Copy link
Collaborator

makasim commented Feb 11, 2016

It is as simple as doing a git revert command on this commit 417a2d5

@florianajir
Copy link

+1

@mangelsnc
Copy link
Contributor Author

It's necessary to create a new PR fixing this?

I think @makasim is right, someone with permissions could revert the commit.

@makasim
Copy link
Collaborator

makasim commented Feb 16, 2016

Everybody can do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants