tapchannel: validate proof courier before opening or accepting channels #1412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make sure users don't run into the issue #1113, we require a universe based proof courier to be configured.
We'll want to test universe proof courier connectivity in a next commit, for which we need a mock gRPC server. We extract the already existing code into the internal test helper package.
We'll need to make sure the connection attempt happens blocking, otherwise we can't be certain that the connection will succeed in the future. This is later improved and made configurable in #1203. For now, we only enable this in the pre-startup check for the universe proof courier.
To make sure the universe proof courier address configured isn't only formally valid but can also be connected to, we do a quick connection check before requesting or accepting a channel funding action.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue that @Liongrass ran into while running
litdon signet: Because the fallback universe proof courier for that network is a hashmail based courier and that type doesn't work with channel funding outputs (due to #1113), we need to make sure a correct courier is configured when opening or accepting Taproot Asset channels.