Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/commands: add offset and limit params to roots cmd #1393

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

guggero
Copy link
Member

@guggero guggero commented Feb 17, 2025

Without these parameters only the first 512 asset roots can be shown.

Without these parameters only the first 512 asset roots can be shown.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13371847609

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 15 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.02%) to 41.034%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/commands/universe.go 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
asset/asset.go 2 77.65%
commitment/tap.go 2 84.32%
internal/test/helpers.go 2 86.95%
tapgarden/planter.go 2 64.98%
tapchannel/aux_leaf_signer.go 3 43.43%
tapgarden/caretaker.go 4 68.11%
Totals Coverage Status
Change from base Build 13371806865: 0.02%
Covered Lines: 27340
Relevant Lines: 66628

💛 - Coveralls

Copy link
Member

@GeorgeTsagk GeorgeTsagk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, ty!

@GeorgeTsagk GeorgeTsagk added this pull request to the merge queue Feb 17, 2025
Merged via the queue into main with commit a261543 Feb 17, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants