Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc CI/build system improvements #1381

Merged
merged 9 commits into from
Feb 18, 2025
Merged

misc CI/build system improvements #1381

merged 9 commits into from
Feb 18, 2025

Conversation

guggero
Copy link
Member

@guggero guggero commented Feb 12, 2025

  • Updates make clean to include more ignored files and directores
  • Updates Go to v1.22.12
  • Makes sure CI doesn't fail just because the Coveralls service has an issue
  • Update sqlc to v1.28.0
  • Update sqlite to v1.34.5
  • Update linter reference commit, enable cache

@guggero guggero requested review from ffranr and gijswijs February 12, 2025 13:34
@guggero
Copy link
Member Author

guggero commented Feb 12, 2025

Added two more commits, one of them fixing #292.

@guggero guggero linked an issue Feb 12, 2025 that may be closed by this pull request
Starting with Go 1.20 the -coverprofile flag does the same that GOACC
did before.
Since we're using Go 1.22 everywhere now, these values are actually the
default now and we don't need to set them anymore.
Copy link
Contributor

@ffranr ffranr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always nice to see a cleanup!

@guggero guggero requested review from GeorgeTsagk and removed request for gijswijs February 18, 2025 09:40
Copy link
Member

@GeorgeTsagk GeorgeTsagk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@GeorgeTsagk GeorgeTsagk added this pull request to the merge queue Feb 18, 2025
Merged via the queue into main with commit bc61c0e Feb 18, 2025
18 checks passed
@guggero guggero deleted the ci-update branch February 18, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

generate and collect coverage reports in itest runs
3 participants