From 4a388f7081f1fe08d3edbc5449381113164a5730 Mon Sep 17 00:00:00 2001 From: Felix Prillwitz Date: Sat, 22 Feb 2025 22:06:58 +0100 Subject: [PATCH 1/2] ignore unknown enum values --- metadata/src/audio/file.rs | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/metadata/src/audio/file.rs b/metadata/src/audio/file.rs index e8fe822bc..62a31be72 100644 --- a/metadata/src/audio/file.rs +++ b/metadata/src/audio/file.rs @@ -49,12 +49,17 @@ impl From<&[AudioFileMessage]> for AudioFiles { .iter() .filter_map(|file| { let file_id = FileId::from(file.file_id()); - if file.has_format() { - Some((file.format(), file_id)) + if let Some(format) = file.format { + match format.enum_value() { + Ok(f) => return Some((f, file_id)), + Err(unknown) => { + trace!("Ignoring file <{}> with unknown format {unknown}", file_id); + } + } } else { trace!("Ignoring file <{}> with unspecified format", file_id); - None } + None }) .collect(); From f0b98da725319e0027de9720d13844407796626d Mon Sep 17 00:00:00 2001 From: Felix Prillwitz Date: Sun, 23 Feb 2025 00:06:51 +0100 Subject: [PATCH 2/2] update CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3e8682f93..92e5c9f0c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -39,6 +39,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - [connect] Fix "play" command not handled if missing "offset" property - [discovery] Fix libmdns zerconf setup errors not propagating to the main task. - [metadata] `Show::trailer_uri` is now optional since it isn't always present (breaking) +- [metadata] Fix incorrect parsing of audio format - [connect] Handle transfer of playback with empty "uri" field - [connect] Correctly apply playing/paused state when transferring playback