Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: privKey possible undefined #129

Merged
merged 1 commit into from
Aug 17, 2020
Merged

Conversation

AuHau
Copy link
Contributor

@AuHau AuHau commented Aug 17, 2020

If pubKey can be undefined then the privKey should be possible to have undefined as well.

Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The privKey will be undefined most of the times, unless it it from the self peer.
Thanks for the PR

@vasco-santos vasco-santos merged commit 224b30c into libp2p:master Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants