Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate isEqual in favor of equals #107

Merged
merged 1 commit into from
Nov 12, 2019
Merged

Conversation

jacobheun
Copy link
Contributor

Resolves #94.

This deprecates isEqual in favor of equals. I added a deprecation notice to the readme about removing support for this whenever we release 0.14. If this looks good I will create an issue to track its removal.

Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vasco-santos vasco-santos merged commit bbf0416 into master Nov 12, 2019
@vasco-santos vasco-santos deleted the feat/equals branch November 12, 2019 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename isEqual to equals (and document)
2 participants