fix: store remote agent and protocol version during identify #943
Conversation
These values were not being stored during identify.
achingbrain
requested review from
vasco-santos and
jacobheun
and removed request for
vasco-santos
|
I did have a couple of questions about this - why is Why are they stored as |
I tracked it down to #724 . I am not sure, probably to be similar to Go? We did try to follow go whenever possible for storing stuff in the stores.
Because we persist the metadataBook content as Uint8Array, as a Datastore Value. In this case, we considered that anything could be stored as metadata, including a serialized protobuf |
test/identify/index.spec.js
Outdated
| await pWaitFor(() => connection.streams.length === 0) | ||
| await connection.close() | ||
|
|
||
| const remotePeer = PeerId.createFromB58String('12D3KooWHFKTMzwerBtsVmtz4ZZEQy2heafxzWw6wNn5PPYkBxJ5') |
There was a problem hiding this comment.
Can we do not have the peerId hardcoded?
There was a problem hiding this comment.
It's taken from https://github.com/libp2p/js-libp2p/blob/master/test/fixtures/browser.js#L6 where it's also hardcoded?
There was a problem hiding this comment.
I thought I would have been able to get it from remoteLibp2p but that var does't appear to be set anywhere in the tests?
There was a problem hiding this comment.
I was meaning, probably more bullet proof to extract the id from the multiaddr
There was a problem hiding this comment.
Aha, have updated it.
vasco-santos
deleted the
fix/store-remote-agent-and-protocol-versions-during-identify
branch
These values were not being stored during identify.