fix: clean up pending dial targets #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the `Promise.race` throws, execution of the function is terminated so the pending dial target is never removed from the map and we leak memory. This can happen when there are invalid multiaddrs or when a peer reports more dialable addresses than the threshold. Instead wrap the `Promise.race` in a `try/finally` which will always remove the pending dial target in the event of success or failure.
vasco-santos
approved these changes
Dec 10, 2021
|
A graph, running IPFS using libp2p master vs this PR. Leave it running for an hour, just idling with the DHT enabled and it running it's query-self query every five minutes. Blue and red lines are heap use in MB. Blue is master, red is this PR. Yellow is the number of network peers we have - low water mark 50, high 100. Samples collected every 10 seconds, using
|
|
Refs ipfs/js-ipfs#3469 |
|
wow, good job @achingbrain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
Promise.racethrows, execution of the function is terminated so the pending dial target is never removed from the map and we leak memory.This can happen when there are invalid multiaddrs or when a peer reports more dialable addresses than the threshold.
Instead wrap the
Promise.racein atry/finallywhich will always remove the pending dial target in the event of success or failure.