Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break examples out into a new repo #292

Closed
Stebalien opened this issue Mar 2, 2018 · 3 comments
Closed

Break examples out into a new repo #292

Stebalien opened this issue Mar 2, 2018 · 3 comments

Comments

@Stebalien
Copy link
Member

This should reduce the code size of this repo and reduce the number of dependencies.

@Kubuxu
Copy link
Member

Kubuxu commented Mar 4, 2018

There were discussions previously about what form this repo should take. For example, should it depend on everything and provide nice interface or should it just contain constructors and helper methods for using libp2p and so on. I can't recall conclusions of them.

@lgierth what do you think?

@Stebalien
Copy link
Member Author

So, one motivation is that the DHT currently depends on this repo so we can't add any examples that use the DHT. (see #278). We could, alternatively:

  • Put that example in the DHT repo.
  • Move the parts of go-libp2p that the DHT actually needs (for tests) in a separate repo.
  • Figure out a better way to deal with test dependencies (multiple gx packages in a single repo).

@anacrolix
Copy link
Contributor

Looks like this was done in #381.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants