Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for multiple subaddress separators #1

Closed
lewxdev opened this issue Apr 4, 2023 · 1 comment
Closed

add support for multiple subaddress separators #1

lewxdev opened this issue Apr 4, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@lewxdev
Copy link
Owner

lewxdev commented Apr 4, 2023

According to Wikipedia, email providers may use different symbol delimiters before the subaddress part because of the lack of standardization. For example, according to the article, yahoo mail uses the hyphen (-) instead of the plus (+). Unfortunately, because I only skimmed the details initially, I missed this and never implemented any safeguards.

In order to support more email providers, this can be solved in one of a few ways:

  1. Use plus (+) by default with some mapped exceptions based on the provider.
  2. Use an extensive map of email providers to subaddress delimiters.

The second option may be better. This way, if the user has an email from a provider we haven't listed, we should assume the provider doesn't support subaddressing and prevent it from being added / prevent later issues.

@lewxdev lewxdev added the bug Something isn't working label Apr 4, 2023
@lewxdev lewxdev self-assigned this Apr 4, 2023
@lewxdev
Copy link
Owner Author

lewxdev commented Oct 14, 2024

will be resolved with #2

@lewxdev lewxdev closed this as completed Oct 14, 2024
@lewxdev lewxdev changed the title Add Support for Multiple Subaddress Delimiters add support for multiple subaddress separators Oct 16, 2024
@lewxdev lewxdev added enhancement New feature or request and removed bug Something isn't working labels Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant