Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLJS namespace that requires CLJ for macros breaks tools.namespace #51

Closed
magnars opened this issue Nov 3, 2015 · 1 comment
Closed

Comments

@magnars
Copy link
Contributor

magnars commented Nov 3, 2015

In quiescent there is both a Clojure and ClojureScript version of quiescent.core, and the cljs-version requires macros from the clj-version:

(ns quiescent.core
  (:require [cljsjs.react])
  (:require-macros [quiescent.core :refer [react-method]]))

This is certainly valid, but it breaks tools.namespace, that is used by quite a few tools.

According to @stuartsierra in this thread, a fix is not likely in the short term.

Any chance you would be willing to rename the clojure ns to something like quiescent.core-macros to work around this shortcoming of tools.namespace?

@magnars
Copy link
Contributor Author

magnars commented Jan 10, 2016

Stuart has now worked around this issue.

@magnars magnars closed this as completed Jan 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant