Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: yes should be default for confirmCommit #85

Merged
merged 1 commit into from
Apr 13, 2019
Merged

fix: yes should be default for confirmCommit #85

merged 1 commit into from
Apr 13, 2019

Conversation

mauricekleine
Copy link
Contributor

We would like to use cz-customizable in our company and we think it makes sense to be able to press ENTER until the end, without any extra effort, until you've created the commit. Hence, we propose to make 'yes' the default option in confirmCommit

@leonardoanalista
Copy link
Member

Hi @mauricekleine thanks for the PR. I absolutely agree yes should be the default always. Do you think we should release this as a breaking change as we are changing the way people use this tool today? Just asking the question because we have 10K downloads a month and I am sure some people could would appreciate to know about the changes before they upgrade. What do you think?

@mauricekleine
Copy link
Contributor Author

@leonardoanalista good point. I agree with you, this should be considered a breaking change, because I reckon if this is part of your muscle memory (pressing 'y' instead of enter), this change might be super frustrating.

@leonardoanalista leonardoanalista merged commit eee6212 into leoforfree:master Apr 13, 2019
@leonardoanalista
Copy link
Member

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@leonardoanalista
Copy link
Member

Great! I merged and changed the commit message to have BREAKING CHANGE in the description. This way semantic-release automatically identifies the breaking change and releases as major. Version 6.0.0 has been released as I was typing here.

@mauricekleine
Copy link
Contributor Author

mauricekleine commented Apr 14, 2019

@leonardoanalista awesome, thank you!

@leonardoanalista
Copy link
Member

No problems. If you have any further suggestions please open an issue at any time 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants