Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config marshal into json #1

Closed
FedorZaytsev opened this issue Jul 24, 2018 · 1 comment
Closed

Config marshal into json #1

FedorZaytsev opened this issue Jul 24, 2018 · 1 comment

Comments

@FedorZaytsev
Copy link

Hi,

I think it will be great to replace mapping config struct into JSON. Usually, fields in JSON have naming with an underscore (_), but you have with space (example: https://github.com/lelvisl/logger/blob/master/logger.go#L14)

What to you think to replace json:"network type" into json:"network_type"
@lelvisl
Copy link
Owner

lelvisl commented Jul 24, 2018

Yep, i’ll fix tag for json encoding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FedorZaytsev @lelvisl