Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all report Dicts by OrderedDict #132

Merged
merged 1 commit into from
Mar 10, 2025
Merged

Replace all report Dicts by OrderedDict #132

merged 1 commit into from
Mar 10, 2025

Conversation

fhagemann
Copy link
Contributor

@fhagemann fhagemann commented Mar 9, 2025

Addressing the issue legend-exp/LegendMakie.jl#29 (comment):

The peaks are always plotted in reverse order (from highest energy peak to lowest). Unsure how much work this is, but it would be cool if they were plotted from lowest to highest peak position.

This is due to the report being a Dict which is by default unordered.
How, such reports will be OrderedDict to preserve the order of the individual reports.

Note: this PR introduces a new light dependency of OrderedCollections.

@fhagemann fhagemann self-assigned this Mar 9, 2025
@fhagemann fhagemann requested a review from theHenks March 9, 2025 20:01
@fhagemann fhagemann added enhancement New feature or request dependencies Pull requests that update a dependency file labels Mar 9, 2025
Copy link

codecov bot commented Mar 9, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 28.36%. Comparing base (6eece2d) to head (e40051d).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/aoe_cut.jl 0.00% 2 Missing ⚠️
src/lqfit.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
- Coverage   28.39%   28.36%   -0.03%     
==========================================
  Files          37       37              
  Lines        3564     3564              
==========================================
- Hits         1012     1011       -1     
- Misses       2552     2553       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@theHenks theHenks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks! This will make plotting much nicer.
Did you test all functions on data? Otherwise this is for me ready to be merged

@fhagemann
Copy link
Contributor Author

No, I did not test this yet on data, but I will within the next hours.

@theHenks
Copy link
Collaborator

I tested the energy part and verified that it works. Let's merge!

@theHenks theHenks merged commit 3d9f9bd into main Mar 10, 2025
13 checks passed
@theHenks theHenks deleted the ordered_dict branch March 10, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants