Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require peakfinder_σ_scaled in sipm_simple_calibration to be an integer #131

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fhagemann
Copy link
Contributor

@fhagemann fhagemann commented Mar 6, 2025

In 8c62c6a, the explicit Int declaration of peakfinder_σ_scaled was removed.
Therefore, we should check if peakfinder_σ_scaled can be converted to an integer (despite fixing the typo in rount)

@fhagemann fhagemann added the bug Something isn't working label Mar 6, 2025
@fhagemann fhagemann requested a review from theHenks March 6, 2025 22:56
@fhagemann fhagemann self-assigned this Mar 6, 2025
@fhagemann fhagemann changed the title Avoid rounding peakfinder_σ_scaled in sipm_simple_calibration Require peakfinder_σ_scaled in sipm_simple_calibration to be an integer Mar 11, 2025
@legend-exp legend-exp deleted a comment from codecov bot Mar 11, 2025
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 28.37%. Comparing base (3d9f9bd) to head (12d0e05).

Files with missing lines Patch % Lines
src/sipm_simple_calibration.jl 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
- Coverage   28.39%   28.37%   -0.02%     
==========================================
  Files          37       37              
  Lines        3564     3566       +2     
==========================================
  Hits         1012     1012              
- Misses       2552     2554       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@theHenks theHenks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, can this be merged or do you want to do further tests @fhagemann?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants