-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increasing fees doesn't check account balance/pending fees/pending STX transfers #3109
Comments
Still happening: #3338 (comment) |
Hi @314159265359879, I did some research on the issue. We are using a hook called There is another hook called One more thing I would like to add, we also have a list of submitted transactions, I think their balance should also be taken into account while calculating the max amount. |
Assigning @alter-eggo to take a look since I believe he's worked on related code recently |
@harrybasra95 Sure |
@314159265359879 wonder if this is still relevant. seems like previous work on available balances fixed this |
@alter-eggo, yes #3525 (pending outgoing STX's transfers) and another fix to subtract pending fees, prevent a lot of cases already. There is still one issue open that should be addressed to catch all of the most common cases (subtract STX transfers due to contract calls based on exact post-conditions): Lets proceed there? |
yeah, let's proceed there |
We are seeing an increased number of forever pending transactions such as this (screenshot):
I think a scenario such as the following plays out:
New users sends three transactions. A pre-order for a domain. A transfer of STX and something else. After waiting two minutes, they believe it is taking to long so they increase the fee on the first transaction to something like 2 STX. Now there is not enough left to cover the fee and transfer of STX (second transaction). The users sends more transaction and they all remain pending for hours... and hours eventually they ask for help.
I am wondering if we can do more to check balance and include the current fees needed to cover pending transactions as well as STX to cover pending transfers out of the wallet so we can error "not enough STX balance to increase the fee to that value" or similar. Instead of getting wallets stuck like this.
I think this is a P2 because it especially happens to new users. More experienced Stackers will know transaction times on Stacks are (currently) longer than on Ethereum. Although in case of real congestion this can affect experienced users too.
The text was updated successfully, but these errors were encountered: