Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstable - Import from other channels - The 'Save search' option is disabled #4711

Closed
pcenov opened this issue Sep 5, 2024 · 5 comments · Fixed by #4719
Closed

Unstable - Import from other channels - The 'Save search' option is disabled #4711

pcenov opened this issue Sep 5, 2024 · 5 comments · Fixed by #4719
Assignees
Labels
bug DEV: frontend P0 - critical Priority: Release blocker or regression TAG: regression

Comments

@pcenov
Copy link
Member

pcenov commented Sep 5, 2024

Observed behavior

Observed while regression testing #4687 - for some reason the 'Save search' button is disabled and I can't save the search term.

Expected behavior

The 'Save search' button should be enabled if I haven't previously saved the same search term.

Steps to reproduce the issue

  1. Go to https://unstable.studio.learningequality.org/en/accounts/#/ and sign in
  2. Open a channel and click Add > Import from other channels
  3. Enter a search term and click the Search button
  4. Attempt to click the 'Save search link' and observe that it's disabled for no obvious reason

Additional information

cannot.save.a.search.mp4

Usage Details

@pcenov
Copy link
Member Author

pcenov commented Sep 5, 2024

@radinamatic

@akolson
Copy link
Member

akolson commented Sep 5, 2024

@pcenov I thinks its disabled because there are no previous searches available. Not sure but I think this was the implementation change @rtibbles? cc @marcellamaki. I think I am confusing the "view saved searches" and "save search".

@akolson akolson added this to the Studio: Bulk Editing Release milestone Sep 5, 2024
@akolson
Copy link
Member

akolson commented Sep 5, 2024

It looks like the first search doesn't enable the link. Subsequent searches seem to enable the link and ability to save

@radinamatic radinamatic added bug P0 - critical Priority: Release blocker or regression DEV: frontend TAG: regression labels Sep 5, 2024
@shivam-daksh
Copy link
Contributor

Hi @akolson and @radinamatic, may I look into this issue?

@akolson
Copy link
Member

akolson commented Sep 9, 2024

Hi @shivam-daksh!

Thank you for the interest in fixing this issue. Unfortunately, this is an issue reported from ongoing testing for our upcoming release, and as such, will be handled by a core team member. Please feel free to check out our backlog for issues with the label help wanted.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug DEV: frontend P0 - critical Priority: Release blocker or regression TAG: regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants