Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Checkbox Labels #4525

Closed
BabyElias opened this issue Apr 19, 2024 · 5 comments · Fixed by #4629
Closed

Missing Checkbox Labels #4525

BabyElias opened this issue Apr 19, 2024 · 5 comments · Fixed by #4629
Assignees
Labels
DEV: frontend P0 - critical Priority: Release blocker or regression TAG: regression

Comments

@BabyElias
Copy link
Member

Observed behavior

Checkbox Labels for the Languages, Licenses and Formats dropdown menus located on the Content Library Page are missing.
image
image

Expected behavior

The following checkbox labels should have been visible.
image
image

User-facing consequences

The absence of the checkbox label may cause confusion and potentially lead to unintended selections.

Steps to reproduce the issue

  1. Navigate to http://localhost:8080/en/channels/#/public
  2. Click the dropdown menu next to Formats/Languages/Licenses

Usage Details

  • OS: Ubuntu
  • Browser: Firefox
@shivansh-bhatnagar18
Copy link
Contributor

@BabyElias @MisRob kindly review the PR #4527 where I have fixed the checkbox labels issue

@bjester bjester added this to the Studio: Q2-24 Release milestone Apr 24, 2024
@bjester bjester added P0 - critical Priority: Release blocker or regression DEV: frontend TAG: regression labels Apr 24, 2024
@shivansh-bhatnagar18
Copy link
Contributor

@bjester Could you please assign me this issue?

@bjester
Copy link
Member

bjester commented Apr 29, 2024

@shivansh-bhatnagar18 I've assigned you! Thank you for reaching out. Please take a look at the linked items in this comment for context on this regression. The problem that I saw with your PR is that it removed text truncation from the languages, which is something you may not encounter in development because of how the filter values are constrained to what results are available. Additionally, the notranslate class is also important. Therefore, I'd suggest you follow the changes that caused the regression and identify the fix to counteract them.

If you encounter questions regarding why something was implemented, I do recommend looking at the git blame and following those commits here on Github to the PR, which should illuminate the reasons. If you're unsure, please ask!

@shivansh-bhatnagar18
Copy link
Contributor

@bjester Could you please help me out with what does this "label" slot mentioned in the template do here because removing it seems to solve the issue.
Screenshot from 2024-05-03 02-36-16

@bjester
Copy link
Member

bjester commented May 2, 2024

@shivansh-bhatnagar18 So for some background, it's our intent to replace all Vuetify components with components from our Kolibri Design System library. We recently accomplished this for checkboxes. Looking at the linked documentation for KCheckbox, there is no #label slot but there is a default slot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: frontend P0 - critical Priority: Release blocker or regression TAG: regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants