Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admins see all channel collections in their account #4145

Closed
bjester opened this issue Jun 14, 2023 · 7 comments · Fixed by #4401
Closed

Admins see all channel collections in their account #4145

bjester opened this issue Jun 14, 2023 · 7 comments · Fixed by #4401

Comments

@bjester
Copy link
Member

bjester commented Jun 14, 2023

Observed behavior

When signed in as an admin, all channel collections from all users are visible.

Expected behavior

We limit this display to only those collections created by the user. We can add a collections browser in the admin if it's needed.

User-facing consequences

Increases the chance of accidentally editing some else's collection

@GarvitSinghal47
Copy link
Contributor

GarvitSinghal47 commented Dec 25, 2023

@bjester @rtibbles i would like to work on this issue , if it is open for contribtion

@bjester
Copy link
Member Author

bjester commented Jan 10, 2024

@GarvitSinghal47 Thank you for your interest. Yes this is open for contribution, and I think it's more straightforward than #1830 if you want to tackle this first. The default account when you run studio in development, a@a.com, should be an admin. You can use the other users to set up this scenario for fixing it.

@GarvitSinghal47
Copy link
Contributor

Hey @bjester 👋, I'm excited to jump into this issue and get it sorted out. Could you please assign it to me? Also, quick question: once I resolve the default admin account scenario, should I only focus on fixing it, or do we need to create another collection place to display all collections as mentioned in the message? Let me know!

@GarvitSinghal47
Copy link
Contributor

Just wanted to double-check if I've got the issue right: it seems like the problem occurs when fetching collections for the first time, and after a user creates a collection, it disappears upon refreshing. Is that an accurate understanding of the issue? Let me know so I can dive in and tackle this! 😊

www_screencapture_com_2024-1-11_13_48.mp4

@bjester
Copy link
Member Author

bjester commented Jan 11, 2024

when fetching collections for the first time, and after a user creates a collection, it disappears upon refreshing

That doesn't sound like the issue, no.

The issue is that when an admin is logged in, they see everyone's collections not just their own, which makes the collections feature not very useful for admins.

@GarvitSinghal47
Copy link
Contributor

GarvitSinghal47 commented Jan 11, 2024

The video I've shared depicts the admin side, where a collection created by users is disappearing. It's important to note that the disappearance is occurring for collections generated by users, not those created by the admin.

I believe the issue described in the message is the same. I apologize for any lack of clarity in my earlier communication.

when fetching collections for the first time, and after a user creates a collection, it disappears upon refreshing

That doesn't sound like the issue, no.

The issue is that when an admin is logged in, they see everyone's collections not just their own, which makes the collections feature not very useful for admins.

@bjester
Copy link
Member Author

bjester commented Jan 11, 2024

@GarvitSinghal47 That seems weird that some collections are disappearing, so yes nothing should disappear but rather show what should be expected-- the logged in user's collections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants