Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passwords do not have any length or character requirements #4142

Closed
bjester opened this issue Jun 14, 2023 · 5 comments · Fixed by #4353
Closed

Passwords do not have any length or character requirements #4142

bjester opened this issue Jun 14, 2023 · 5 comments · Fixed by #4353

Comments

@bjester
Copy link
Member

bjester commented Jun 14, 2023

Observed behavior

An account was created in the hotfixes server environment with a password of a.

Expected behavior

We should have a basic minimum length threshold for passwords, at the very least. In development mode, the password a should still work.

User-facing consequences

Shorter passwords are easier to breach and Studio is an online platform where it's important to have this.

@cerdo03
Copy link
Contributor

cerdo03 commented Dec 8, 2023

Hi, I wanted to pick up this issue, can you guide me how can I check if it is development mode so that the password validation is not valid for dev server?

@cerdo03
Copy link
Contributor

cerdo03 commented Dec 8, 2023

Are there any other validations that need to be implemented?

@MisRob
Copy link
Member

MisRob commented Dec 12, 2023

Thank you, @cerdo03! We will review.

@bjester
Copy link
Member Author

bjester commented Dec 13, 2023

Are there any other validations that need to be implemented?

@cerdo03 Adding a length check to the backend would also be worthwhile, if you're familiar with python/django. Otherwise, no worries about that.

@cerdo03
Copy link
Contributor

cerdo03 commented Dec 13, 2023

Yeah I am familiar with django, I'll implement the password validation and raise the updated PR soon. Thanks for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants