Fix change facility workflow #13165
Open
Fix change facility workflow #13165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
APP: User
Build Artifacts
|
|
Habemus facility change and account merging again, hallelujah!!! 🎉 🎉 🎉 I also went through the LoD setup with account on server (import and new), just for kicks, and still all good 💯 |
|
@radinamatic does this mean that Alex's work here has fixed the (neglected) work in progress I had for one of the previous alpha releases, or that's still separately a problem? #13097 It seems the same root cause (composition api changes in the code syntax) but perhaps just he has actually found all of the places where the problems were |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After the vue upgrade to vue 2.7, this
statecomputed property that was the context of the state machine provided by theChangeFacilityindex component had a change: When we refer to this injected property from the setup method, we need to access it through the.valueproperty, but when we access it through the options api we dont need the.valueproperty anymore. This basically caused the entire change facility workflow to break.In the course of that refactor I somehow fixed the underlying issue that was causing #12762 (that wasnt initially caused by the vue upgrade since it was reported before that).
Compartir.pantalla.-.2025-03-06.14_04_34.mp4
References
Closes #12762
Reviewer guidance
Note
stateinjected prop in the whole ChangeFacility folder, and validated that all references to it inside thesetupmethod was being referenced with the.valueproperty, and all the references outside thesetupmethod was being referenced without the.valueproperty. But a double check never hurts :)