-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content download request progress tracking #10391
Comments
Hi @bjester, can I help with this task? |
@Jaspreet-singh-1032 Yes, I followed up in our slack channel. You may skip the updates to the component |
Hello @bjester, can you please tell me how can I trigger and test this process? |
@Jaspreet-singh-1032 I added some manually testing instructions to the issue |
Thanks! |
Hi @bjester, I could not get time to work on it last week. But now I have resumed work on this one. I have set up two instances of Kolibri locally for admin and learner. And will let you know about the further implementation. |
Hi @Jaspreet-singh-1032, could you share a progress update? |
Yes @bjester, can we pass the And assign Let me know what do you think about this. |
@Jaspreet-singh-1032 Yes that should work fine. Since this is a very specific use case, I think it's generally wise to think about how this could be integrated without directly coupling the two, but the changes are few so we could revisit it another time. It could make sense to add a |
Thanks. Sure, I will add a classmethod in |
What is |
I thought of adding it because this is how currently |
I think having a new |
Let me see if we can make it work only with one progress field. |
@Jaspreet-singh-1032 When do you expect a PR to be opened? |
Actually, I was currently working on it. I know it gets late but I will be opening a PR in the upcoming days maybe before this weekend. |
Thank you @Jaspreet-singh-1032 |
Depends on: #10365
Summary
With #10365, we implemented the automatic import of content assigned in lessons and exams. The automatic import also processes user-initiated downloads in addition to sync-initiated downloads. For user-initiated downloads, the user can see the state the current state of the download request. It would be helpful to surface the actual progress percentage of the download request, because users with low-bandwidth connections, or downloads of large files, could take a while.
Deliverables
The mixin class
JobProgressMixin
The function
process_download_request
JobProgressMixin
, inherited byRemoteChannelResourceImportManager
, to attach a method that will update theContentDownloadRequest
with the progress of the downloadContentRequest
field or themetadata
fieldThe component
MyDownloads
References
https://learningequality.slack.com/archives/CB37UM23A/p1679665808045409
Setting up manual testing scenario
Be sure to use separate Kolibri home directories for each instance by using the environment variable
KOLIBRI_HOME
For Instance A
For Instance B
Further testing
To continue testing the automatic content import you may:
The text was updated successfully, but these errors were encountered: