replace corrupts binary files

[tcoopman]

When gulp-replace runs on binary files, it corrupts them. gulp-replace should ignore binary files.

[nfroidure]

You could filter binary files with gulp-filter.

[tcoopman]

That's correct and I do that, but I still consider this a bug (gulp-replace should not corrupt files!)

[grahamb]

👍 for this - gulp-filter should only attempt to filter plain-text files, not binaries.

[lazd]

@grahamb, you can use gulp-filter to stop gulp-replace from entering binary files. Did that approach not work for you?

[grahamb]

It does, but unless I'm mis-understanding how gulp-filter works, I have to filter by a glob (e.g. a filename), not file name. So, right now I've got var filter = gulpFilter(['!**/*.jar', '!**/*.png']);. If I (or someone else, or some other automated process) adds a .jpg file to the repo, then I've got to manually filter that as well.

I'd love to be disabused of this notion if I'm wrong.

[grahamb]

It's worth noting that ant (which hilariously is what I'm in the process of converting from) also has the same problem; if you use the ant copy task with a filter (ant-speak for replacing strings in a file with values from a java .properties file) it also corrupts the binaries. You have to do similar acrobatics (copy the files you want to filter first, excluding things with certain extensions, then copy the rest, without using a filter). I was hoping we'd advanced a bit more beyond that in the intervening 14 years 😉

[tcoopman]

I believe that it should be possible to embed something like this: https://github.com/bevry/istextorbinary ?

[nfroidure]

the @tcoopman approach could do the trick, but, it should be behind an option since it could slows down the plugin.