Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-cache; max-age=0 vs no-cache, max-age=0 #208

Closed
pjanik opened this issue Feb 2, 2016 · 1 comment
Closed

no-cache; max-age=0 vs no-cache, max-age=0 #208

pjanik opened this issue Feb 2, 2016 · 1 comment

Comments

@pjanik
Copy link
Contributor

pjanik commented Feb 2, 2016

CloudFront doesn't want to update my files, even though I've set max-age to 0 in s3_webiste config.
Files uploaded by old version of s3_website work as expected. I've noticed that that files uploaded by the latest version use no-cache; max-age=0 header while old version was setting no-cache, max-age=0.
Not sure about correct and/or accepted format (would need to dig into some specs), but comma seems to be widely used. I haven't found examples with semi-colon.
Not sure, but maybe CloudFront gets confused and uses default TTL instead of max-age value?
Anyone experiencing similar issues or able to replicate it?

@laurilehmijoki
Copy link
Owner

Thank you @pjanik for pointing out this bug. You are right: the separator in Cache-Control should be ,, not ;.

I've just released the fix in the version 2.12.3.

The commit is here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants