-
Notifications
You must be signed in to change notification settings - Fork 267
Move ownership of this repo? #74
Comments
Hey @vkammerer, I wrote: https://github.com/bendrucker/angular-credit-cards Those two cover almost all the features of angular-payments, with the exception of card formatting (which is coming with heavy unit + Protractor testing). They also have 100% test coverage and better organized APIs. Given the long backlog here, I'm very interesting in bringing users over to those two libraries and reviewing feature requests. |
Thank you for sharing the info @bendrucker. I would be very interested in it as soon as card formatting is supported 👍 |
For those interested, I shipped a number of upstream updates this weekend: The latter is particularly relevant for people who want formatting. I'll see if I can cut a prerelease this week since the minimum number of test cases I'm willing to ship with will presumably take longer to write than the actual code. |
Also, if there were any doubts about how hard input masking can be: Stripe Checkout, with a bunch of talented engineers serving a ton of users, ships with easily reproducible formatting bugs. Formatting definitely helps fewer users mistype their card number, but the net effect is small if it also royally pisses off users who catch their own typo. So I'd definitely encourage people to pick battle tested code versus opting for a feature like formatting at the cost of bugs and a poor API. Planning to ship formatting this month as an opt-in and eventually transition it to an opt-out. |
@bendrucker cool! thanks |
Formatting is now available behind the |
Note that the repos above https://github.com/bendrucker/angular-credit-cards aren't being actively developed either, as the author doesn't "use Angular anymore". See bendrucker/angular-credit-cards#67 and use at your own risk. |
@twler He also doesn't push his built libraries to npm so they're essentially useless for people who only want to use gulp/grunt. |
Hi @laurihy ,
You haven't replied to any of the issues filed in the last months. Do you want to transfer the ownership of this repo to someone who could dedicate enough time to maintain it?
The text was updated successfully, but these errors were encountered: