Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Check for non-null return value from fread to handle character z… #15

Merged
merged 3 commits into from
Jul 29, 2023
Merged

fix: Check for non-null return value from fread to handle character z… #15

merged 3 commits into from
Jul 29, 2023

Conversation

igorblumberg
Copy link

As detailed here #13 the input fails if "0" is typed.

This is happening because fread(STDIN, 1024) is returning "0" but fread(STDIN, 1024) ?:"" returns "".

@jessarcher
Copy link
Member

Thanks! 🙏

I solved a similar bug in e979362 but then regressed it in ffe3ae6 🤦‍♀️

@jessarcher jessarcher merged commit 312db87 into laravel:main Jul 29, 2023
@jessarcher jessarcher mentioned this pull request Jul 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igorblumberg @jessarcher