Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action Events trait collapses, but state is not kept after refresh. #6736

Closed
rderks88 opened this issue Feb 12, 2025 · 2 comments
Closed

Action Events trait collapses, but state is not kept after refresh. #6736

rderks88 opened this issue Feb 12, 2025 · 2 comments
Labels
bug Verified bug by the Nova team fix incoming A fix is in review
Milestone

Comments

@rderks88
Copy link

  • Laravel Version: 10.48.27
  • Nova Version: 5.2.1
  • PHP Version: 8.2

Description:

When you collapse the "action events" relation, which is added through the "Actionable" trait, it does not stay closed after page refresh.

Detailed steps to reproduce the issue on a fresh Nova installation:

  • Create a model that uses the actionable trait.
  • Create a resource for that model
  • Execute an action on that resource
  • The action events should show up with one record
  • Collapse the relation
  • f5
  • It keeps on loading in an uncollapsed state

Probable solution

  • Laravel Nova 4 regardless of calling ->collapsable() on a relation, stored the state when you collapsed the relation.
  • Related issue (undocumented change in behaviour from 4 to 5): Relationship collapsed state not stored anymore #6726 (comment)
  • I guess the "action events" relation is added by default, based on the Actionable trait being available on the model. The default should be "collapsable()" im guessing for this relation? Why would you always want this relation to load.
@crynobone crynobone added bug Verified bug by the Nova team fix incoming A fix is in review labels Feb 12, 2025
@crynobone crynobone added this to the 5.2.x milestone Feb 13, 2025
@rderks88
Copy link
Author

You are the best! So fast! Thank you

Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Verified bug by the Nova team fix incoming A fix is in review
Projects
None yet
Development

No branches or pull requests

2 participants