Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type aliases in beta-reduction of polyfunctions #17054

Merged
merged 2 commits into from
Mar 23, 2023
Merged

Fix type aliases in beta-reduction of polyfunctions #17054

merged 2 commits into from
Mar 23, 2023

Conversation

nicolasstucki
Copy link
Contributor

Fixes #17052

@nicolasstucki nicolasstucki marked this pull request as ready for review March 6, 2023 16:29
@nicolasstucki nicolasstucki requested a review from smarter March 6, 2023 16:29
smarter
smarter previously approved these changes Mar 6, 2023
View reviewed changes
@smarter smarter enabled auto-merge March 6, 2023 16:36
@nicolasstucki nicolasstucki dismissed smarter’s stale review March 7, 2023 07:57

New code was added

@nicolasstucki nicolasstucki disabled auto-merge March 8, 2023 10:43
@nicolasstucki nicolasstucki requested a review from pikinier20 March 8, 2023 13:01
@nicolasstucki
Copy link
Contributor Author

nicolasstucki commented Mar 8, 2023 •
edited
Loading

getScaladoc2Type was implemented by taking the output of show and then regexing it. As the output of show is unstable, the behavior of getScaladoc2Type changed. I fixed it by implementing getScaladoc2Type. @KacperFKorban could you have a look at the implementation? Not the change in how implicit arguments changed. Now they introduce a space, I do not know if that can cause problems.

@nicolasstucki nicolasstucki mentioned this pull request Mar 9, 2023
Closed
@nicolasstucki nicolasstucki added this to the 3.3.1-RC1 milestone Mar 14, 2023
@nicolasstucki nicolasstucki removed the request for review from pikinier20 March 17, 2023 15:57
KacperFKorban
KacperFKorban reviewed Mar 22, 2023
View reviewed changes
Copy link
Member

@KacperFKorban KacperFKorban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the implementation looks good. The only place that needs tweaking is the implicit parameters part -- added a separate comment about that.

@nicolasstucki nicolasstucki force-pushed the fix-17052 branch 2 times, most recently from 8f9a98d to 21ee1da Compare March 23, 2023 15:00
@nicolasstucki
Implement getScaladoc2Type without using tree show
6a05f66 
Showing the tree or type does not return a reliable representation. The
only way to create this correctly is be creating a custom printer that
prints in the required format.
@nicolasstucki
Fix type aliases in beta-reduction of polyfunctions
1c2ceae 
Fixes scala#17052
@nicolasstucki nicolasstucki enabled auto-merge March 23, 2023 17:15
@nicolasstucki nicolasstucki merged commit ee2bfdb into scala:main Mar 23, 2023
@nicolasstucki nicolasstucki deleted the fix-17052 branch March 23, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarter smarter smarter approved these changes

@KacperFKorban KacperFKorban KacperFKorban approved these changes

Assignees

@KacperFKorban KacperFKorban

Labels
None yet
Projects
None yet
Milestone
3.3.1
Development

Successfully merging this pull request may close these issues.

Failure when beta-reducing polymorphic function
4 participants
@nicolasstucki @smarter @KacperFKorban @pikinier20