Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: tap target of the menu in Mobile version #17018

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

Dedelweiss
Copy link
Contributor

@Dedelweiss Dedelweiss commented Feb 27, 2023

In this PR, I increase the size of the target taps of the opening and closing menu buttons in the mobile version.

  • Open button
    Before:

Screenshot 2023-02-27 at 15 35 37

After:

Screenshot 2023-02-27 at 15 30 21

  • Close button
    Before:

Screenshot 2023-02-27 at 15 36 06

After:

Screenshot 2023-02-27 at 15 31 03

Closes #16834

@Dedelweiss Dedelweiss changed the title Add padding and width to the mobile menu #16834 Fix tap target of the menu in Mobile version Feb 27, 2023
@Dedelweiss Dedelweiss changed the title Fix tap target of the menu in Mobile version Fix: tap target of the menu in Mobile version Feb 27, 2023
Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is perfect @Dedelweiss, thanks!

LGTM!

@ckipp01 ckipp01 merged commit 416b3c2 into scala:main Feb 28, 2023
@Dedelweiss Dedelweiss deleted the tap_target_mobile_menu branch February 28, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile menu has a very very small tap target
2 participants