-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add table of content to static sites #14607
Add table of content to static sites #14607
Conversation
I just realized that this approach won't work well if the section is longer than one page. This PR can't be merged until we fix it. |
@pikinier20 what do you mean by “the section longer than one page”? The PR sounds like a great improvement :) Do you have a screenshot? |
I mean that if the content of section is longer than one screen, then the javascript that highlights proper sections won't work. It checks if the header of section is present on page. With longer content, the header is invisible but the content is still on the screen. |
9699b6d
to
67062aa
Compare
@julienrf You can see how it looks here: https://scala3doc.virtuslab.com/pr-rhs-table-of-content/scala3/docs/reference/overview.html |
67062aa
to
a0f612f
Compare
I've refactored the arrows since they were a bit inconsistent with the rest of the design. Right now, the anchors to previous and next page are located at the bottom of the page like in e.g. webhelp format. |
I find that the links to the previous and next pages are hard to see. Would it be possible to move them above the list of contributors, maybe? |
a0f612f
to
85ed11d
Compare
That's not that easy because contributors are added by another template :/ |
@julienrf I've moved the arrows above contributors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Filip!
I think this is good to go.
No description provided.